More tests #313
Merged
More tests #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I get very frequent build failures due to the mutual Scala<->Java dependency. It builds for a long time, then decides that getCtx overrides nothing. The only way to fix is another clean build. Total time lost: >5 minutes. These happened occasionally before but have become much more frequent under ScalaIDe4.0, to the point where this becomes a major drag on productity. Context escape detection is nice but if it stops us getting work done, not worth the effort.
The problem was that, unlike a classDefSig, a higher-kinded typeDefSig did not get a preset info with its type parameters. So any type-application of the defined type in its bounds would fail.
Moved some working test to pos. I wonder why they were in pending? They did work for me.
Fixes problem in test case SI-7638a.scala which gave an override error before.
isUnboundedGeneric imples !JavaDefined anyway.
scalac has the same restriction. The reason is that we do not have a means to specify a sequence-valued default for a vararg parameter. It would be nice if we could, but this requires a more substantial development effort.
Move some tests into proper slots + comments what they are.
|
If there are no objections let's merge this now. I will have other PRs that depend on this one. |
DarkDimius
added a commit
that referenced
this pull request
Jan 9, 2015
This was referenced Jun 4, 2017
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "Dealias before checking for member in lint" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch that successively tries to fix more tests. Everyone is invited to review. In the interest of keeping the workflow smooth I am not going to flood the list with PRs if the fix is non-controversial. Difficult fixes will get their own PRs. But simple ones and simple verifications that some tests work will appear here.